Chris d'Arcy Node Eval#178
Open
cmdarcy wants to merge 20 commits into
Open
Conversation
| // create constants for tests | ||
| const validUser = { userName: 'yellowleopard753', password: 'jonjon' }; | ||
| const user = users.find((u) => u.login.username === validUser.userName); | ||
| const invalidUsers = [ |
There was a problem hiding this comment.
always include the word mock as these are not real
Suggested change
| const invalidUsers = [ | |
| const invalidUsersMock = [ |
| { password: 'valid' }, | ||
| {}, | ||
| ]; | ||
| const incorrectUsers = [ |
| describe('/GET brands/:brandId/products', () => { | ||
| it('should respond with 404 status when the supplied brand does not exist', (done) => { | ||
| const brandId = '7'; | ||
|
|
| }); | ||
| }); | ||
|
|
||
| it('should treat an empty searchTerm the same as not supplying one', (done) => { |
| res.should.have.status(200); | ||
| res.body.should.be.an('array'); | ||
| res.body.should.not.be.empty; | ||
| res.body[0].should.have.all.keys( |
There was a problem hiding this comment.
you are not really testing here the search functionality, you need to make sure the actual data is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.