Redux Eval#19
Open
acl13 wants to merge 13 commits into
Open
Conversation
Comment on lines
+3
to
+7
| <div className="row p-3 border-top"> | ||
| <div className="col-sm text-center fw-bold">City</div> | ||
| <div className="col-sm text-center fw-bold">Temperature (F)</div> | ||
| <div className="col-sm text-center fw-bold">Pressure (hPa)</div> | ||
| <div className="col-sm text-center fw-bold">Humidity (%)</div> |
There was a problem hiding this comment.
dry, you can use .map to do this more efficiently
Comment on lines
+5
to
+11
| <div className="col-sm"> | ||
| <Sparklines data={data}> | ||
| <SparklinesCurve color={color} /> | ||
| <SparklinesReferenceLine type="avg"></SparklinesReferenceLine> | ||
| </Sparklines> | ||
| <p className="text-center">{text}</p> | ||
| </div> |
| const onSearch = async () => { | ||
| //Prevents user from submitting an empty search | ||
| if (city.trim() === "") { | ||
| alert("Please enter a valid city"); |
There was a problem hiding this comment.
alerting is not a great UX, consider displaying the error properly
| alert( | ||
| "Oops, something went wrong. Please check that you have entered a valid city and try again." | ||
| ); | ||
| setCity(""); |
There was a problem hiding this comment.
dry, create a function that handles this, will with readability
| ></SearchBar> | ||
| <HeadingsRow /> | ||
| {data && | ||
| cityWeatherData.map((city) => ( |
Comment on lines
+98
to
+108
| <WeatherDataChart | ||
| data={city.temperatureData} | ||
| color={"orange"} | ||
| text={city.temperatureAverage} | ||
| /> | ||
| <WeatherDataChart | ||
| data={city.pressureData} | ||
| color={"green"} | ||
| text={city.pressureAverage} | ||
| /> | ||
| <WeatherDataChart |
There was a problem hiding this comment.
you could have done another map here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.