Levy's RTK Weather#11
Open
levydowell wants to merge 5 commits into
Open
Conversation
| */ | ||
| const findAvg = (data, avgType) => { | ||
| const typeData = data.map((datum) => datum.main[avgType]); | ||
| console.log('here', typeData, typeData.length); |
| * | ||
| * @returns react component containing all of the weather data for each city entered. | ||
| */ | ||
| export const AllData = () => { |
There was a problem hiding this comment.
This name is a bit to generic. Personally, prefer something more like specific that will allow me understand from the file name what the component is responsible for. i.e.
CityWeatherData
Comment on lines
+11
to
+14
| <body className={inter.className}> | ||
| <Provider store={store}>{children}</Provider> | ||
| </body> | ||
| </html> |
Comment on lines
+13
to
+17
| return ( | ||
| <main> | ||
| <InputField /> | ||
| </main> | ||
| ) |
| const latitude = response.payload[0].lat; | ||
| const longitude = response.payload[0].lon; | ||
| dispatch(fetchWeather( {latitude, longitude} )) | ||
|
|
| onChange={(e) => setInput(e.target.value)} /> | ||
| <button className='btn btn-primary' type='button' onClick={handleClick}>Search</button> | ||
| </div> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styling isn't the greatest, but I need to move on for now.