Carly Burkhart Complete#146
Open
TimeIsOnMySide wants to merge 12 commits into
Open
Conversation
lmicek
reviewed
Sep 5, 2023
| @@ -0,0 +1 @@ | |||
| node_modules/* No newline at end of file | |||
| @@ -0,0 +1,12 @@ | |||
| const mongoose = require('mongoose') | |||
| const Schema = mongoose.Schema | |||
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
if you want, you can combine this with your other one and just have one package for the whole project
| import './App.css' | ||
| import ProductList from './features/products/ProductList' | ||
|
|
||
| function App() { |
There was a problem hiding this comment.
I would still change this to a function expression - I know this is how react default outputs this but just a suggestion.
|
|
||
| .product-list-container h2 { | ||
| font-size: 24px; | ||
| margin-bottom: 20px; |
There was a problem hiding this comment.
px is kind of an older way to define spacing in css, read this for more info https://engageinteractive.co.uk/blog/em-vs-rem-vs-px
| const fetchCategories = async () => { | ||
| try { | ||
| const response = await fetch('http://127.0.0.1:8000/products') | ||
| const data = await response.json() |
There was a problem hiding this comment.
I would add the address to a variable so its easy to change on the fly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.