Skip to content

Contacts page w/ out extensions#89

Open
m8ximus wants to merge 2 commits into
projectshft:mainfrom
m8ximus:main
Open

Contacts page w/ out extensions#89
m8ximus wants to merge 2 commits into
projectshft:mainfrom
m8ximus:main

Conversation

@m8ximus

@m8ximus m8ximus commented Aug 29, 2023

Copy link
Copy Markdown

I completely forgot to do lots of commits, I'll be sure to do that moving forward.

Comment thread src/App.js
</div>
);

const Contacts = () => (

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to see some of this broken out into other component files

Comment thread src/App.js
</div>
);
}
ContactCreate.propTypes = {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on propTypes

Comment thread src/App.js
"image": 'https://cdn-icons-png.flaticon.com/512/1144/1144760.png'
};
const handleClick = (props) => {
const generateId = () => Math.round(Math.random() * 100000000)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semi-colons at end of lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants