Set the number of rows using the SearchBuilder#3870
Merged
Conversation
cjcolvar
reviewed
Jun 1, 2026
Comment on lines
+151
to
+157
| extra_controller_params.delete(:rows) | ||
| query = search_builder | ||
| .with(search_state) | ||
| .where(blacklight_config.document_model.unique_key => ids) | ||
| .merge(blacklight_config.fetch_many_document_params) | ||
| .merge(extra_controller_params) | ||
| query.rows(ids.count) |
Contributor
There was a problem hiding this comment.
It seems like it was possible to pass a rows value that was different than the length of the id array. How about retaining that for backwards compatibility?
Suggested change
| extra_controller_params.delete(:rows) | |
| query = search_builder | |
| .with(search_state) | |
| .where(blacklight_config.document_model.unique_key => ids) | |
| .merge(blacklight_config.fetch_many_document_params) | |
| .merge(extra_controller_params) | |
| query.rows(ids.count) | |
| requested_rows = extra_controller_params.delete(:rows) | |
| query = search_builder | |
| .with(search_state) | |
| .where(blacklight_config.document_model.unique_key => ids) | |
| .merge(blacklight_config.fetch_many_document_params) | |
| .merge(extra_controller_params) | |
| query.rows(requested_rows || ids.count) |
Member
Author
There was a problem hiding this comment.
Yes, it was possible to do that, but is there a use case for that?
jcoyne
force-pushed
the
set_rows_with_search_builder
branch
from
4c7460a to
fc2279e
Compare
This enables us to switch to an alternative repository backend
jcoyne
force-pushed
the
set_rows_with_search_builder
branch
from
fc2279e to
ccbb983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables us to switch to an alternative repository backend