-
Notifications
You must be signed in to change notification settings - Fork 47
WIP: Preset editor #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kblaschke
wants to merge
14
commits into
projectM-visualizer:master
Choose a base branch
from
kblaschke:preset-editor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Preset editor #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes live compilation of expression code.preset-editor Also fixed some issues in the editor control and made Milkdrop expressions case-insensitive.
In a multi-line change, the last line wasn't colorized when applying a redo operation.
Users can now indent and unindent lines using the tab key: - If no selection is active, pressing tab only inserts a tab or n spaces at the cursor position - With no selection, pressing shift+tab unindents the current line one step - If a selection is active, tab indents and shift+tab unindents all lines touched by the selection (with at least one character selected at the last line) - Unindented lines with less than the tab size characters of whitespace will be fully unindented - Lines with mixed indentation will be unindented using the proper number of spaces per tab if a tab char needs to be broken down (e.g. unindenting SSTSS with 4 characters will become SSSS) The editor can be configured to insert tab (\t, 0x09) characters or mTabSize number of spaces.
Toggles drawing of the whole child as interfering with the user-resizable window makes ImGui forget the previously set height when expanding it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a Dear ImGui based preset editor within the application, with the following features:
The PR is still a draft, as the save functionality is still WIP as the save to file dialog needs to be implemented. I've opened the Pr to make the feature more visible, as the editor itself already works and thus can be tested by interested devs.
Binary test builds can be found in my fork for Linux x64, macOS (Universal) and Windows x64. Note that the artifacts can only be downloaded when logged in to GitHub.