288-hotfix-fix-createstreetcodehandler#289
Merged
Merged
Conversation
Ammoniy
requested review from
a team,
ArturOleksiuk,
LausDio,
LekhivOleh,
VolodymyrShapoval,
chups98 and
shribakb1
LekhivOleh
approved these changes
Dec 30, 2025
LekhivOleh
approved these changes
Dec 30, 2025
LekhivOleh
left a comment
LekhivOleh
left a comment
Contributor
There was a problem hiding this comment.
Workflows are down, fix then good
|
ArturOleksiuk
approved these changes
Dec 30, 2025
ArturOleksiuk
left a comment
ArturOleksiuk
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nice fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev
Code reviewers
Summary of issue
During error handler implementation TransactionScope in createStreetcodeHandler was deleted, so now even when stretcode creation failed handler still saves unfinished version of streetcode
Summary of change
returned TransactionScope to prevent early save of streetcode
Testing approach
ToDo
CHECK LIST