Task/270/[LogIn using Google Auth] /Implement frontend#23
Closed
InnetaSh wants to merge 9 commits into
Closed
Conversation
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-island-094fe5703-23.westeurope.7.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
The current authentication system lacks support for Google OAuth, requiring users to log in only via traditional email and password credentials. This limits user accessibility and streamlines the onboarding process.
Summary of change
Implemented Google OAuth authentication on the frontend.
Integrated @react-oauth/google provider in the application root.
Added a GoogleLogin component to the LoginPage.
Updated UserApi to include a new googleLogin endpoint, sending the idToken to the backend for verification.
Configured environment variables to securely handle the Google Client ID.
Testing approach
Verified that the Google login button renders correctly on the LoginPage.
Checked the onSuccess callback to ensure the idToken is successfully received from Google.
Tested the API interaction to confirm that the backend receives the token and returns the expected authentication response.
Verified that the userLoginStore correctly updates the application state upon a successful Google login.
Confirmed that unauthorized attempts or errors are caught and handled with user-friendly error messages via antd notification.
CHECK LIST