Skip to content

Add loading spinners to Account Settings buttons#710

Open
kevinaboos wants to merge 1 commit intomainfrom
add-loading-spinners-account-settings-13843479116470563411
Open

Add loading spinners to Account Settings buttons#710
kevinaboos wants to merge 1 commit intomainfrom
add-loading-spinners-account-settings-13843479116470563411

Conversation

@kevinaboos
Copy link
Member

This PR implements loading spinners for the AccountSettings widget buttons as requested in issue #693.

Changes:

  • Added LoadingSpinner widgets to AccountSettings layout.
  • Added avatar_upload_pending and avatar_delete_pending fields to AccountSettings struct.
  • Updated handle_actions to manage pending states.
  • Updated draw_walk to bind spinner visibility to pending states.

PR created automatically by Jules for task 13843479116470563411 started by @kevinaboos

Added LoadingSpinner widgets next to the "Upload Avatar", "Delete Avatar", and "Save Name" buttons in the AccountSettings widget.
Implemented separate state tracking for avatar upload and delete actions (`avatar_upload_pending` and `avatar_delete_pending`) to avoid shared state issues.
Updated logic to toggle spinner visibility based on these states.
The spinners provide visual feedback during async operations.

Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant