Skip to content

Add tests for mode +l#333

Open
progval wants to merge 8 commits intomasterfrom
limit
Open

Add tests for mode +l#333
progval wants to merge 8 commits intomasterfrom
limit

Conversation

@progval
Copy link
Owner

@progval progval commented Jan 10, 2026

No description provided.

@github-actions
Copy link

Test results

@progval
Copy link
Owner Author

progval commented Jan 10, 2026

Reported to Unreal at https://bugs.unrealircd.org/view.php?id=6602

and to Ergo at ergochat/ergo#2324

@progval
Copy link
Owner Author

progval commented Jan 10, 2026

Spec PR to formalize testLimitWithInvite: ircdocs/modern-irc#269

but not all IRCds support it so I'm not sure what do to with testLimitWithInvite.

@slingamn
Copy link
Collaborator

The ergo issue here should be fixed in irctest_stable now.

@slingamn
Copy link
Collaborator

re. testLimitWithInvite can we just mark all the ircds that don't support it as expected-fail? That seems OK for a MAY in the Modern spec, if it's a widely implemented and useful feature.

@progval
Copy link
Owner Author

progval commented Jan 20, 2026

no, expected-fail is SHOULD/MUST. For MAY it's raise runner.ImplementationChoice("...")

@slingamn
Copy link
Collaborator

But at a pragmatic level, that allows implementations that support the feature to silently regress, right?

@progval
Copy link
Owner Author

progval commented Jan 21, 2026

yes

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

Test results

@slingamn
Copy link
Collaborator

slingamn commented Feb 8, 2026

@progval irc2 is unmaintained so we should just x-fail it here, right?

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

Test results

@progval
Copy link
Owner Author

progval commented Feb 8, 2026

yes

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

Test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants