Copy a link from a chat message (#908)#967
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #908.
Right-clicking a link in a chat message did nothing on packaged desktop builds: the native WebView context menu is globally suppressed, and message links were plain
<a>with no menu of their own.What changed
LinkContextMenupopover — Copy link / Open in browser — mirroring the existingImageContextMenu.MessageLinkcomponent (right-click only, so it never double-fires with the bubble's long-press); its menu is portalled todocument.bodysoposition: fixedsurvives the virtualizer's row transforms.openInBrowserhelper intoutils/openInBrowser.ts; added anextractLinkshelper reusing the renderer's URL regex.chat.copyLink/chat.copyLinkChooseacross all 33 locales.