fix(muc): use profile username as default nick everywhere (#920)#964
Merged
Conversation
MUC joins now default to the profile username (XEP-0172 PEP nick), falling back to the bare-JID local part, via a single shared helper resolveDefaultMucNick. Previously two paths ignored the profile nick: accepting a room invitation joined under the JID local part, and fetchBookmarks hardcoded 'user' when a bookmark carried no <nick>. The three join modals already used the profile nick and are refactored onto the same helper so every call site agrees. An autojoin bookmark that omits <nick> now rejoins under the resolved default instead of being silently skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #920.
The app didn't consistently use the profile username (XEP-0172 PEP nick) as the default MUC nickname. The manual join modals already did, but two paths ignored it:
fetchBookmarkshardcoded'user'when a bookmark had no<nick>.This adds a single shared helper
resolveDefaultMucNick(ownNickname, jid)(profile nick → JID local part, whitespace-hardened) and routes all five call sites through it, including the three join modals for consistency.Side effect: an autojoin bookmark that omits
<nick>now rejoins under the resolved default instead of being silently skipped.