Open
Conversation
Switch from session-per-run to tab-per-run model: each job now runs in a named tab inside a shared session, reducing session proliferation and enabling tab-level liveness checks. Propagate errors from zellij CLI calls via Result<bool> instead of silently returning false. Expose ZellijAdapter in the public API, add zellij-tests feature gate, update CLI help text and attach hints, and add a feature-gated integration test for the full spawn→tab→attach path. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_is_running/session_existsfrombooltoResult<bool>so zellij CLI errors surface instead of being silently swallowedtab_exists()helper (viazellij action query-tab-names) for tab-level liveness checks inis_alive()andattach()ZellijAdapterinrunbox-core's public API (lib.rsre-export)zellij-testsfeature flag inrunbox-cli/Cargo.toml(mirrors existingtmux-testspattern) to gate integration tests that require a live zellij binary--runtimehelp text andattachcommand docs to reflect zellij parity with tmuxtest_attach_zellijintegration test covering the full spawn → tab-create → attach pathAcceptance Criteria
spawn()creates a background session, opens a named tab, runs the command with--close-on-exit, and verifies the tab exists before returning aRuntimeHandlezellij.rsdiff — three-stepsession_output→tab_output→run_outputsequence with tab verificationis_alive()checks both session running AND tab existsis_alive()now callssession_is_running(session).unwrap_or(false) && tab_exists(session, tab).unwrap_or(false)session_is_running/session_existsreturnResult<bool>with.context(...)on every zellij CLI call.output().context("...")and returnOk(...)/bail!(...)ZellijAdapterre-exported fromrunbox-corelib.rsdiff addsZellijAdapterto thepub use runtime::linezellij-testsfeature added toCargo.toml; integration test gated with#[cfg(feature = "zellij-tests")]Cargo.tomldiff +attach.rstest function annotation--runtimearg docs updated to listzellijalongsidetmux; attach hint shown for both runtimes incmd_run_replaymain.rsdiff — three--runtimehelp strings updated +matches!(runtime, RuntimeType::Tmux | RuntimeType::Zellij)guardtest_attach_background_not_supportedandtest_attach_no_runtime_not_supportednow expect"only supported for tmux/zellij"attach.rsdiff lines 67 and 110git statusshowsnothing to commit, working tree cleangit push -u origin issue/ISSUE-031/run-20260308-105100succeeded with new branch created on remoteNotes
Refs: ISSUE-031