Restore Result compatibility on safe VM leak-fix base#363
Open
Restore Result compatibility on safe VM leak-fix base#363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the VM leak-fix line on the last known safe base and add back the legacy
doeff._vendor.Resultshim required by current proboscis-ema imports.This intentionally avoids the later deferred-segment cleanup commits that reintroduced the
RuntimeError: internal error: no current segmentfailure under the TRD-023 pipeline shape.Verification
uv run pytest tests/test_vm_memory_leak.py -qin proboscis-ema with doeff revd6ae0c81715a53c563cdf55087b139a9ad6c79873 passed in 73.42suv run --with mpmath python -m doeff run --program proboscis_ema.doeff.trading.entrypoints.trd023_report.p_trd023_report_5d_3model_pos5pctRuntimeError: internal error: no current segmentNameResolutionErrorforinfluxdb.proboscis-ema.svc.cluster.localIssue: vm-rust-memory-leak