Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py: PythonfromKleisli::{apply, apply_with_run_token}andIRStreamProgram::start, while pushing Python attachment into Python-backed implementationsRustKleisliStreamGIL wrappers and add/update regression tests for the new call signatures and dispatch object reuseValidation
cargo test --manifest-path packages/doeff-vm-core/Cargo.tomlPYTHONHOME=/home/kento/.local/share/uv/python/cpython-3.14.0b1+freethreaded-linux-x86_64-gnu PYO3_PYTHON=/home/kento/.orch/worktrees/vm-perf-gil-cleanup/5c5ab6_codex_20260314-164318/.venv/bin/python LD_LIBRARY_PATH=/home/kento/.local/share/uv/python/cpython-3.14.0b1+freethreaded-linux-x86_64-gnu/lib cargo test --manifest-path packages/doeff-vm/Cargo.tomluv run pytest packages/doeff-vm-core/tests/test_gil_cleanup_architecture.pyuv run pytest tests/->1193 passed, 12 skippeduv tool run semgrep --config .semgrep.yaml packages/doeff-vm-core/src/vm/step.rs packages/doeff-vm-core/src/kleisli.rs packages/doeff-vm-core/src/handler.rs packages/doeff-vm-core/src/vm/dispatch.rs packages/doeff-vm-core/src/vm/vm_trace.rs->0 findingsAcceptance Criteria
Kleisli::apply/apply_with_run_tokenno longer takepy:packages/doeff-vm-core/src/kleisli.rs,packages/doeff-vm-core/src/handler.rsIRStreamProgram::startno longer takespy:packages/doeff-vm-core/src/handler.rs,packages/doeff-core-effects/src/handlers/mod.rs,packages/doeff-core-effects/src/scheduler/mod.rsRustKleisliStream::resume/throwno longer wrapPython::attach:packages/doeff-vm-core/src/kleisli.rsdispatch_to_pyobjectis materialized once and passed into handler expansion throughensure_dispatch_effect_object(...):packages/doeff-vm-core/src/vm/dispatch.rs,packages/doeff-vm-core/src/vm/vm_trace.rsNotes
cargo test --manifest-path packages/doeff-core-effects/Cargo.tomlalready fails onorigin/mainat baseline commit9aa8f77cbecause the crate test target aliasesDispatchEffect = Effect, which diverges from thedoeff-vm-coretrait signature. This PR does not introduce that failure.vm-perf-gil-cleanup