docs(docs): exclude PostgreSQL from "different database" note in NestJS guide#7545
docs(docs): exclude PostgreSQL from "different database" note in NestJS guide#7545gideonadeti wants to merge 1 commit intoprisma:mainfrom
Conversation
…JS guide The default setup uses @prisma/adapter-pg (PostgreSQL). The note is for users on a different database; listing PostgreSQL there was contradictory.
|
@gideonadeti is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughDocumentation update to the NestJS framework guide clarifying database driver adapter installation requirements. The guidance now specifies MySQL and SQL Server adapter installation when deviating from the default PostgreSQL configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/docs/content/docs/guides/frameworks/nestjs.mdx (1)
66-70: LGTM — the fix is accurate and removes a genuine contradiction.The original text was misleading because it listed PostgreSQL as a case requiring a "different" adapter, when the entire guide is built around
@prisma/adapter-pgas the default. Prisma maintains adapters for several drivers, and now that PostgreSQL is correctly treated as the default, the remaining examples — MySQL and SQL Server — accurately represent the cases where a developer would need to swap out the adapter.One optional consideration: SQLite is a very common Prisma target (TypedSQL works with all supported driver adapters except
@prisma/adapter-better-sqlite3; for SQLite support,@prisma/adapter-libsqlis recommended) and might be worth mentioning alongside MySQL and SQL Server to help developers who reach for SQLite for local dev. That said, the existing "Database drivers" link already provides the full picture, so the note works well as-is.✏️ Optional: broaden the examples to include SQLite
-If you are using a different database provider (MySQL, SQL Server), install the corresponding driver adapter package instead of `@prisma/adapter-pg`. For more information, see [Database drivers](/orm/core-concepts/supported-databases/database-drivers). +If you are using a different database provider (MySQL, SQL Server, SQLite), install the corresponding driver adapter package instead of `@prisma/adapter-pg`. For more information, see [Database drivers](/orm/core-concepts/supported-databases/database-drivers).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/docs/content/docs/guides/frameworks/nestjs.mdx` around lines 66 - 70, The note incorrectly suggested PostgreSQL required a different adapter; update the info block so it clarifies that PostgreSQL uses the default `@prisma/adapter-pg` and that developers need to swap the adapter only for other databases — explicitly list MySQL and SQL Server and optionally add SQLite as a common example (mention `@prisma/adapter-libsql` for SQLite and note `@prisma/adapter-better-sqlite3` is excluded), keeping the existing "Database drivers" link for full details.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/docs/content/docs/guides/frameworks/nestjs.mdx`:
- Around line 66-70: The note incorrectly suggested PostgreSQL required a
different adapter; update the info block so it clarifies that PostgreSQL uses
the default `@prisma/adapter-pg` and that developers need to swap the adapter only
for other databases — explicitly list MySQL and SQL Server and optionally add
SQLite as a common example (mention `@prisma/adapter-libsql` for SQLite and note
`@prisma/adapter-better-sqlite3` is excluded), keeping the existing "Database
drivers" link for full details.
@prisma/adapter-pg(PostgreSQL).Summary by CodeRabbit