feat(client-engine-runtime): Support KSUID and Prefixed TypeID#27471
Open
kayandra wants to merge 1 commit intoprisma:mainfrom
Open
feat(client-engine-runtime): Support KSUID and Prefixed TypeID#27471kayandra wants to merge 1 commit intoprisma:mainfrom
kayandra wants to merge 1 commit intoprisma:mainfrom
Conversation
|
|
This was referenced Jun 20, 2025
aqrln
requested changes
Jul 2, 2025
Member
aqrln
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! This is a good start, however this also needs:
- Schema validation
- Proper integration tests in
packages/client/tests/functional - Support for it in https://github.com/prisma/prisma-engines/blob/c717abe28d5e8e01b58d43e0c0134630791630c4/query-engine/query-structure/src/field/scalar.rs#L239 so the query compiler knows they exist and can embed them to the generated query plans (which are interpreted by the code you modified here)
- The implementation in https://github.com/prisma/prisma-engines/blob/c717abe28d5e8e01b58d43e0c0134630791630c4/query-engine/query-structure/src/default_value.rs#L306 so that the query engine also knows what to do with them when the query compiler is not used.
Author
|
Alright, I'll make the changes and push |
|
I'd like to help with this PR, if it's still active |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for two new id generators
Checklists
TypeID<'prefix'>instead of string. I may need some guidance on this.model User {}getstypeid(<user>)as suggestion.P.S if there's something important I have to do to get these merged please let me know.