test: make the multiple_create_index_concurrently test portable to cockroachdb

[jacek-prisma]

Modified the test slightly so that it works with both cockroach and postgres

Fixes failing CI: https://github.com/prisma/prisma-engines/actions/runs/24400153666/job/71268254670

/test-all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 96bee22b-e6ba-4dd6-8968-303ed1342eca

📥 Commits

Reviewing files that changed from the base of the PR and between 8c28700 and 3c3fb2d.

📒 Files selected for processing (1)

• schema-engine/sql-migration-tests/tests/migrations/postgres.rs

---

Summary by CodeRabbit

• Tests
  • Updated database migration test cases to enhance validation of schema changes across multiple database platforms.

Walkthrough

Updated a PostgreSQL migration test file to replace the Cat table schema with a Person schema, including column type changes, index updates, datamodel modifications, and addition of database-specific conditional logic for column type assertions.

Changes

Cohort / File(s)	Summary
PostgreSQL Migration Test schema-engine/sql-migration-tests/tests/migrations/postgres.rs	Updated test data from Cat table (INTEGER ID, name/age columns with indexes) to Person table (TEXT ID, quoted firstName/lastName columns with indexes). Changed second migration from 02add_breed to 02add_role, updated datamodel and assertions accordingly. Added conditional logic to set column type based on database type (Cockroach vs. others).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: making the multiple_create_index_concurrently test portable to CockroachDB, which aligns with the changeset that modifies test logic to handle both database backends.
Description check	✅ Passed	The description is directly related to the changeset, explaining that the test was modified to work with both CockroachDB and Postgres, and references the failing CI run that prompted the fix.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/make-create-index-concurrent-portable

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch test/make-create-index-concurrent-portable

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codspeed-hq]

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks¹

---

_{Comparing test/make-create-index-concurrent-portable (3c3fb2d) with main (8c28700)}

Footnotes

1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[github-actions]

Wasm Query Compiler File Size

Engine	This PR	Base branch	Diff
Postgres	3.505MiB	3.505MiB	0.000B
Postgres (gzip)	1.142MiB	1.142MiB	4.000B
Postgres (size-optimized)	1.766MiB	1.766MiB	0.000B
Postgres (size-optimized, gzip)	694.906KiB	694.998KiB	-94.000B
Mysql	3.458MiB	3.458MiB	0.000B
Mysql (gzip)	1.127MiB	1.127MiB	2.000B
Mysql (size-optimized)	1.736MiB	1.736MiB	0.000B
Mysql (size-optimized, gzip)	684.228KiB	684.225KiB	3.000B
Sqlite	3.376MiB	3.376MiB	0.000B
Sqlite (gzip)	1.098MiB	1.098MiB	-4.000B
Sqlite (size-optimized)	1.692MiB	1.692MiB	0.000B
Sqlite (size-optimized, gzip)	667.293KiB	667.295KiB	-2.000B
SQL Server	3.593MiB	3.593MiB	0.000B
SQL Server (gzip)	1.160MiB	1.160MiB	-1.000B
SQL Server (size-optimized)	1.765MiB	1.765MiB	0.000B
SQL Server (size-optimized, gzip)	698.008KiB	698.045KiB	-38.000B
CockroachDB	3.555MiB	3.555MiB	0.000B
CockroachDB (gzip)	1.160MiB	1.160MiB	2.000B
CockroachDB (size-optimized)	1.791MiB	1.791MiB	0.000B
CockroachDB (size-optimized, gzip)	705.230KiB	705.223KiB	7.000B