release(v0.34.7): bump 4 manifests + ratchet floors + enable devtools#90
Merged
Conversation
What ---- Cut release v0.34.7 to ship PR #89 (desktop enrollment-paste handler fix). Bump 4 protocol manifests 0.34.6 → 0.34.7 and 4 desktop version files 1.0.2 → 1.0.3. Ratchet 4 floor tests 0.34.6 → 0.34.7. Re-enable the `devtools` Tauri feature in release builds (mandatory per the ztlp-desktop-release skill so operators can right-click → Inspect on shipped installers to triage UI bugs). Why --- PR #89 is a pure desktop JS fix but ships as a desktop installer, so the release tag is monotonic with the protocol patch version per the ztlp-desktop-release skill convention (same convention v0.34.5 followed for the previous desktop hotfix). Floors track the new release per release-version-pinning Pitfall 13 — without ratcheting the floor at 0.34.6 stays viable as a tripwire only for pre-0.34.6 down-bumps, which is dead surface against v0.34.7+. devtools-in-release was inadvertently dropped at some point on this branch — the release-skill checklist confirms it's a release invariant and v0.34.5 had it on. Restoring matches established norms. Details ------- Protocol manifests (4 files, 0.34.6 → 0.34.7): - proto/Cargo.toml - relay/mix.exs - ns/mix.exs - gateway/mix.exs Floor tests (4 files, 0.34.6 → 0.34.7): - proto/tests/version_pin_test.rs (MINIMUM_VERSION const) - relay/test/ztlp_relay/release_test.exs (Version.compare floor) - ns/test/ztlp_ns/release_test.exs (Version.compare floor) - gateway/test/ztlp_gateway/release_test.exs (Version.compare floor) Desktop manifests (4 files, 1.0.2 → 1.0.3): - desktop/src-tauri/Cargo.toml - desktop/src-tauri/tauri.conf.json - desktop/package.json - desktop/src/index.html (sidebar footer label) Desktop Cargo.lock auto-regenerated by cargo check. Tauri feature change (desktop/src-tauri/Cargo.toml): features = ["tray-icon"] → features = ["tray-icon", "devtools"] Per ztlp-desktop-release skill §3 invariant. Comment block above the line documents why (PR #89's WebView2 inline-handler bug took ~2 hours to repro entirely because the previous release shipped without devtools). Each manifest also gets an inline comment block per release-version-pinning naming this PR and the regression-test floor that pins it. Tests ----- RED step (recorded before bump): proto/Cargo.toml version 0.34.6 is older than the v0.34.7 strict-routing tag. Bump `version = "..."` in proto/Cargo.toml. GREEN step (all four after bump): proto: cargo test --test version_pin_test test cargo_pkg_version_is_at_least_minimum_floor ... ok test cargo_pkg_version_is_parseable_semver ... ok test result: ok. 2 passed; 0 failed relay: mix test test/ztlp_relay/release_test.exs 15 tests, 0 failures ns: mix test test/ztlp_ns/release_test.exs 15 tests, 0 failures gateway: mix test test/ztlp_gateway/release_test.exs 15 tests, 0 failures Validation ---------- - All four floors RED before bump (proves the tripwires work), GREEN after. - `cargo check` clean for proto (bin ztlp) and desktop (ztlp-desktop). - No stale "1.0.2" or "0.34.6" references in repo source (grep excluding Cargo.lock dependency entries). - Tauri config invariants per ztlp-desktop-release pre-tag checklist: * app.withGlobalTauri: true ✓ (unchanged from PR #86) * Cargo.toml tauri features include "devtools" ✓ (restored here) Follow-up --------- - Tag v0.34.7 from this PR's merge commit. release.yml will build all 15 artifacts (5 Rust archives + 3 OTP releases + 4 desktop installers + eBPF + 2 metadata). - Deploy desktop installer to bench 10.170.3.111 per ztlp-desktop-release §8. AHK-verifiable: PR #89's enroll-paste end-to-end already confirmed on a hand-swapped build of fd0e30d; v0.34.7 = fd0e30d + manifest bumps, so functional behavior is unchanged from that verification. - 5 other desktop components (home, identity, services, setup, settings) still use the broken inline-handler pattern (20+ attributes). Fix template is identical to PR #89; not blocking this release.
|
Warning Review limit reached
More reviews will be available in 27 minutes and 42 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cut release v0.34.7 to ship PR #89 (desktop enrollment-paste handler fix).
devtoolsTauri feature re-enabled for release per ztlp-desktop-release skill §3 invariantWhy
PR #89 is desktop-only JS but ships as a desktop installer, so the protocol patch version moves monotonically per the same convention v0.34.5 followed for the previous desktop hotfix. Floors track new release per release-version-pinning Pitfall 13.
Tests (RED → GREEN)
RED (before bump):
```
proto/Cargo.toml version 0.34.6 is older than the v0.34.7
strict-routing tag. Bump `version = "..."` in proto/Cargo.toml.
```
GREEN (after bump):
Pre-tag checklist (per ztlp-desktop-release skill)
app.withGlobalTauri: true(unchanged)Validation
Follow-up