Skip to content

fix#67

Merged
HoseokWon99 merged 1 commit into
prgrms-fullstack-devcourse:mainfrom
HoseokWon99:main
Aug 11, 2025
Merged

fix#67
HoseokWon99 merged 1 commit into
prgrms-fullstack-devcourse:mainfrom
HoseokWon99:main

Conversation

@HoseokWon99

Copy link
Copy Markdown
Contributor

No description provided.

@HoseokWon99 HoseokWon99 requested a review from ksy90101 as a code owner August 11, 2025 01:15
@HoseokWon99 HoseokWon99 merged commit bba0720 into prgrms-fullstack-devcourse:main Aug 11, 2025
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @HoseokWon99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed a critical bug in how range values are parsed and validated across the application. Previously, the system could only correctly interpret single-digit numbers within a range string, leading to validation failures for larger numbers. This change ensures that multi-digit numbers are now properly handled, improving the robustness of user input validation for properties like experience and birthyear ranges.

Highlights

  • Range Validation Fix: The IsRange decorator's regular expression has been updated to correctly parse and validate range strings containing multi-digit numbers (e.g., "10-20"). This resolves an issue where only single-digit numbers were recognized.
  • Number Type Validation Update: The validation for experience and positionIds properties in SearchUsersFilters has been updated from @ISINT to @isnumber. This change aligns with the broader range validation capabilities and ensures compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates validation rules in DTOs. It correctly broadens a regular expression to allow multi-digit numbers in a range filter. However, it also changes an integer validation (@IsInt) to a general number validation (@IsNumber) for positionIds. This is inconsistent with other ID fields and could allow incorrect data, so I've recommended reverting that specific change.


@ArrayMinSize(1)
@IsInt({ each: true })
@IsNumber({}, { each: true })

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For consistency and correctness, positionIds should be validated as integers. This property, like techIds and interestIds which still use @IsInt, represents entity identifiers which are typically integers. Using @IsNumber allows for floating-point values, which could lead to unexpected behavior or invalid data. It's recommended to revert this to use @IsInt.

Suggested change
@IsNumber({}, { each: true })
@IsInt({ each: true })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant