Support for VS2015 through VS2022 in Premake 4#20
Open
assarbad wants to merge 4 commits into
Open
Conversation
Does not add the VisualStudioVersion and MinimumVisualStudioVersion in solution files, but VS2015 opens those fine regardless and picks them up first even when VS2010, 2012 and 2013 are installed as well. Added corresponding tests and verified that all is as expected.
There are also minor fixes, such as for CompileAs and other conditions. It actually also required changing two test cases, because implicitly the default are C++ projects, so adding .c files should add CompileAs, but didn't in the past.
It appears the true string in modern versions is "Visual Studio Version <version>" not just "Visual Studio <version>". Still need to figure out which of the VS versions changed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @starkos,
I finally got around to work on rebasing my fork on your Git repo. IIRC we both used Hg once upon a time, then you and I separately migrated to Git, commit hashes diverged etc. I traced the common ancestor to a9141de and
git replace-d my history for the one from your premake-4.x repo. This way they should be compatible.I then rebased onto your
masterbranch, since it seemed the sensible thing to do, just squashing a single commit that touched only the.hgignorefile.The result should cleanly work and be true to the Premake 4 spirit without adding the other stuff I added in my WDS fork.
My commits are signed (thus didn't tick the "allow edits" checkbox).
Best regards,
Oliver
PS: more will follow, such as the support for VS2026. It's not a big deal, but since I am doing the work now, I am also cleaning the history a little.