Mobkoi: Always set the TagID with our placementID #4327
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a discrepancy between our Prebid Server and our Tag/PrebidJS integration. It’s not replacing the `bidrequest.Imp[0].TagID` with our internal value when a TagID is already present. We are able to deliver because the value is set in the `bidrequest.Imp[0].Ext.placementID` field, but this creates discrepancies between the connectors, and it’s not ideal.
CTMBNara
requested changes
Jan 5, 2026
Comment on lines
+98
to
+128
| @Test | ||
| public void makeHttpRequestsShouldOverrideExistingTagIdWithPlacementId() { | ||
| final ObjectNode mobkoiExt = impExt("placement-id-from-ext"); | ||
| final Imp givenImp1 = givenImp(impBuilder -> impBuilder.tagid("existing-tag-id").ext(mobkoiExt)); | ||
| final Imp givenImp2 = givenImp(identity()); | ||
| final BidRequest bidRequest = BidRequest.builder().imp(asList(givenImp1, givenImp2)).build(); | ||
| final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest); | ||
|
|
||
| assertThat(result.getValue()) | ||
| .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class)) | ||
| .flatExtracting(BidRequest::getImp) | ||
| .extracting(imp -> imp.getTagid()) | ||
| .containsExactly("placement-id-from-ext", null); | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| } | ||
|
|
||
| @Test | ||
| public void makeHttpRequestsShouldKeepExistingTagIdWhenPlacementIdIsMissing() { | ||
| final ObjectNode mobkoiExt = impExt(null); | ||
| final Imp givenImp1 = givenImp(impBuilder -> impBuilder.tagid("existing-tag-id").ext(mobkoiExt)); | ||
| final Imp givenImp2 = givenImp(identity()); | ||
| final BidRequest bidRequest = BidRequest.builder().imp(asList(givenImp1, givenImp2)).build(); | ||
| final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest); | ||
|
|
||
| assertThat(result.getValue()) | ||
| .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class)) | ||
| .flatExtracting(BidRequest::getImp) | ||
| .extracting(imp -> imp.getTagid()) | ||
| .containsExactly("existing-tag-id", null); | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Add // given // when // then
| final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest); | ||
|
|
||
| assertThat(result.getValue()) | ||
| .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class)) |
| assertThat(result.getValue()) | ||
| .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class)) | ||
| .flatExtracting(BidRequest::getImp) | ||
| .extracting(imp -> imp.getTagid()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
We have a discrepancy between our Prebid Server and our Tag/PrebidJS integration. It’s not replacing the
bidrequest.Imp[0].TagIDwith our internal value when a TagID is already present. We are able to deliver because the value is set in thebidrequest.Imp[0].Ext.placementIDfield, but this creates discrepancies between the connectors, and it’s not ideal.