Improved NVIDIA support out-of-the-box and other fixes#8
Merged
Conversation
…oice relationships
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces improved support for NVIDIA graphics cards out-of-the-box and fixes inconsistencies and other issues as listed in the CHANGELOG. Closes #4
This PR also moves the version to v1.2.0
Added
runtime: nvidiain generateddocker-compose.ymland the__GLX_VENDOR_LIBRARY_NAME=nvidiaenvironment variable to ensure correct GPU offloading and OpenGL vendor selection./dev/drivolume mounts for Linux hosts and explicit installation oflibgl1,libglvnd-dev, andlibegl1for vendor-neutral GL dispatch.desktop-fullnow automatically imply required packages (rviz2,gazebo/gz_sim), and GUI packages automatically enablex11display forwarding.resolve_config()method in both Python and JS core modules to handle automatic dependency resolution and OS-specific scaffolding.tests/test_output_shape.pyto verify repo-root workspace mounts, shell config generation, NVIDIA compose behavior, and README/package consistency.tests/test_web_bundle.pyto verify the website zip export contains the expected files and preserves byte-identical generated content.CI/validate.shfor writable default workspaces,colcon mixin list, and Oh My Zsh ownership in generated non-root containers.scripts/run_act.shhelper for reproducible sequentialactruns without introducing third-party JS dependencies.Changed
docker-compose.ymlto prefer theruntime: nvidiadirective over the legacydeploy: resourcesblock for broader compatibility outside of Swarm.prime-select nvidiahints).docker-compose.ymlnow mounts the current directory into the configured ROS workspace by default instead of creating a nested./ros2_wsbind mount..bashrcwhenbashrcis selected and into.zshrcwhenzshis selected.desktop-full, matching the web UI instead of only applying those implications at final generation time.actrunner behavior.usermode and current host UID mapping for dev-container readiness.ros2-<distro>container name and default tool selection set.Dockerfile,docker-compose.yml, andREADME.md, and localactruns now execute jobs sequentially with matrix fan-out capped to keep disk usage manageable.Fixed
/rootinstead of the selected non-root user.Dockerfilebefore the generated compose setup could build.GAZEBO_PLUGIN_PATHwas exported manually.