Conversation
- Move pendingCaptureTabs from in-memory Map to session storage to survive service worker restarts - Make manifest permissions conditional: offscreen only for Chrome, tabs only for E2E builds - Disable test-activate page in non-E2E builds for security - Fix offscreen message listener to use sendResponse callback pattern - Add quota error handling with automatic cleanup retry in storage utils - Set allFrames: false explicitly on content script
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 47.75% 47.51% -0.25%
==========================================
Files 35 35
Lines 1562 1572 +10
Branches 326 329 +3
==========================================
+ Hits 746 747 +1
- Misses 703 712 +9
Partials 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pendingCaptureTabsfrom in-memory Map to session storage to survive service worker restartsoffscreenonly for Chrome,tabsonly for E2E buildssendResponsecallback patternallFrames: falseexplicitly on content scriptTest plan