Skip to content

fix: persist pending captures in session storage and refine permissions#5

Merged
pproenca merged 1 commit intomasterfrom
fix/pending-capture-storage-and-manifest-permissions
Feb 2, 2026
Merged

fix: persist pending captures in session storage and refine permissions#5
pproenca merged 1 commit intomasterfrom
fix/pending-capture-storage-and-manifest-permissions

Conversation

@pproenca
Copy link
Copy Markdown
Owner

@pproenca pproenca commented Feb 2, 2026

Summary

  • Move pendingCaptureTabs from in-memory Map to session storage to survive service worker restarts
  • Make manifest permissions conditional: offscreen only for Chrome, tabs only for E2E builds
  • Disable test-activate page in non-E2E builds for security
  • Fix offscreen message listener to use sendResponse callback pattern
  • Add quota error handling with automatic cleanup retry in storage utils
  • Set allFrames: false explicitly on content script

Test plan

  • Unit tests pass (193 tests)
  • TypeScript compiles without errors
  • ESLint passes
  • E2E tests pass in CI
  • Extension loads and activates correctly in Chrome
  • Pending capture flow resumes after service worker restart

- Move pendingCaptureTabs from in-memory Map to session storage to survive
  service worker restarts
- Make manifest permissions conditional: offscreen only for Chrome, tabs
  only for E2E builds
- Disable test-activate page in non-E2E builds for security
- Fix offscreen message listener to use sendResponse callback pattern
- Add quota error handling with automatic cleanup retry in storage utils
- Set allFrames: false explicitly on content script
@pproenca pproenca merged commit d6f5847 into master Feb 2, 2026
4 checks passed
@pproenca pproenca deleted the fix/pending-capture-storage-and-manifest-permissions branch February 2, 2026 13:01
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.51%. Comparing base (b64f2a7) to head (717580d).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
utils/storage.ts 0.00% 9 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   47.75%   47.51%   -0.25%     
==========================================
  Files          35       35              
  Lines        1562     1572      +10     
  Branches      326      329       +3     
==========================================
+ Hits          746      747       +1     
- Misses        703      712       +9     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants