Updating version in tests#8
Open
jorgefandinno wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the test suite and CI configuration to support newer version combinations and to normalize some test/program string formatting.
Changes:
- Reformats several tests to inline triple-quoted program/reification strings directly in
solve(...)/generate(...)calls. - Tweaks test helper/type-hint formatting (e.g., trailing commas in signatures).
- Expands the GitHub Actions matrix (Python/clingo versions) and bumps action versions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_solver_reification.py |
Formatting-only change to inline the triple-quoted reification string passed to solve(). |
tests/test_generator_reification.py |
Formatting-only change to inline the triple-quoted reification string passed to generate(). |
tests/test_eclingo.py |
Formatting-only changes to inline multi-line programs passed to solve(). |
tests/helper_build_programs.py |
Signature formatting update (reveals a return type annotation mismatch). |
tests/build_programs.py |
Refactors file-writing calls for generated program output; header text remains but contains misleading instructions. |
.github/workflows/test.yml |
Updates CI matrix and action versions; currently introduces invalid YAML due to incorrect steps indentation. |
Comments suppressed due to low confidence (1)
tests/build_programs.py:169
- The generated-file header contains typos and incorrect paths/commands (
DO NO MODIFY,test/programs.py,python test/build_programs.py). This makes the instructions misleading for contributors because the repository uses thetests/directory.
"""
DO NO MODIFY THIS FILE MANUALLY!
This file is generated by tests/build_programs.py
Modify the file "test/programs.py" and run "python test/build_programs.py" instead.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
31
to
+35
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v3 | ||
| uses: actions/setup-python@v6 |
Comment on lines
47
to
51
| - name: Clingo version | ||
| id: clingo-version | ||
| run: | | ||
| echo "CLINGO_VERSION=$(python -c 'import clingo; print(clingo.__version__)')" >> $GITHUB_ENV | ||
|
|
Comment on lines
110
to
112
| def build_candidate( | ||
| candidate: Union[str, Tuple[str, str]] | ||
| candidate: Union[str, Tuple[str, str]], | ||
| ) -> Optional[List[Candidate]]: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.