-
Notifications
You must be signed in to change notification settings - Fork 140
E2E test: log system diagnostics during test run, clean up extraneous test processes, & run against a past commit #11371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
testlabauto
wants to merge
21
commits into
main
Choose a base branch
from
cmead/test-system-diagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+409
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
Add missing `!failure() && !cancelled()` guards and fix formatting for consistency with other jobs in the workflow. The e2e-chromium job was being skipped even when inputs.run_e2e_browser was true, causing matrix child jobs to remain in "Waiting for pending jobs" state indefinitely. Changes: - Add !failure() && !cancelled() guards to e2e-electron and e2e-chromium - Remove extra space in e2e-chromium if condition - Add parentheses around condition for consistency with other jobs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gather basic data as tests complete during a run and optionally allow it to log to console.
Allow running tests from an older revision.
Provide --init param to containers so that defunct processes are cleaned up.
Better clean up of test processes to mitigate zombies.
Provide dbus setup with xvfb config to eliminate dbus daemon zombies.
@:win