-
Notifications
You must be signed in to change notification settings - Fork 140
Add preview mode support for Data Explorer tabs #11363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add new setting `dataExplorer.enablePreview` (default: true) that controls whether Data Explorer tabs open in preview mode. When enabled, tabs open with italicized names and are replaced by the next Data Explorer opened, matching VS Code's text file preview behavior. - Add configuration setting and helper function in positronDataExplorerSummary.ts - Update positronDataExplorerService.ts to use setting for runtime data frames - Update positronDataExplorerEditor.contribution.ts for file-based data (CSV, Parquet)
|
E2E Tests 🚀 |
| properties: { | ||
| [DATA_EXPLORER_ENABLE_PREVIEW_KEY]: { | ||
| type: 'boolean', | ||
| default: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed this in detail yet, but we'll need to default to false here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
juliasilge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution!
Summary
Adds a new setting
dataExplorer.enablePreviewthat controls whether Data Explorer tabs open in preview mode, addressing user feedback about tab clutter when clicking through multiple CSV files.Addresses #11289
QA Notes
@:data-explorer
Testing Steps
Preview mode enabled (default):
dataExplorer.enablePreviewis checked (true)Preview mode disabled:
dataExplorer.enablePreviewRuntime data frames:
Tab interactions: