fix: correct source link generation#245
Merged
Merged
Conversation
griffe's `Object.filepath` is a property that raises ValueError when the object has no parent module (e.g. synthetic objects in tests). A bare `getattr(..., None)` only suppresses AttributeError, so the ValueError propagated and crashed rendering. Catch both explicitly and fall through to the existing None handling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source links on API reference pages were built from griffe's
relative_package_filepath(), which is relative to the package's parent directory (a griffe search path). Forsrc/-layout projects this drops the leadingsrc/, producing GitHub blob URLs that 404. This PR computes the source path relative to the repository root from the object's absolute filepath (preserving src/ and other non-flat layouts) and honors the existing source.path override for monorepos, bringing the inline SOURCE link in line with the already-correct logic in_build_github_source_url().