Skip to content

PWX-47673 | PWX-47672 | Add support for imagePullPolicy, annotations and verbose operator logs#817

Merged
hitesh-wani-px merged 3 commits into
pre-release-portworx-7.0.3from
customer-req-PWX-47673-PWX-47672
Oct 14, 2025
Merged

PWX-47673 | PWX-47672 | Add support for imagePullPolicy, annotations and verbose operator logs#817
hitesh-wani-px merged 3 commits into
pre-release-portworx-7.0.3from
customer-req-PWX-47673-PWX-47672

Conversation

@hitesh-wani-px

@hitesh-wani-px hitesh-wani-px commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This PR includes the following customer PR changes:

  • Added support for imagePullPolicy and annotations — #775
  • Added support for operator verbose logs — #781
  • Priority class changes will be included in the next operator release.

Which issue(s) this PR fixes (optional)
Closes :

Special notes for your reviewer:

@hitesh-wani-px

Copy link
Copy Markdown
Collaborator Author

Testing note:

  1. Enable and disable operator verbose logs
    helm install my-release ./charts/portworx -n portworx --create-namespace --set verboseOperatorLogs=false
    containers:
      - command:
        - /operator
        - --driver=portworx
        - --leader-elect=true
        env:
        - name: OPERATOR_NAME
          value: portworx-operator
    helm install my-release ./charts/portworx -n portworx --create-namespace --set verboseOperatorLogs=true
    containers:
      - command:
        - /operator
        - --verbose
        - --driver=portworx
        - --leader-elect=true
        env:
        - name: OPERATOR_NAME
          value: portworx-operator
  2. Add annotations on storagecluster
    helm upgrade my-release ./charts/portworx -n portworx --create-namespace --debug --set  clusterAnnotations="portworx.io/evict-vms-during-update=true;example.io/test=true"
    apiVersion: core.libopenstorage.org/v1
    kind: StorageCluster
    metadata:
       annotations:
          example.io/test: "true"
          meta.helm.sh/release-name: my-release
          meta.helm.sh/release-namespace: portworx
          portworx.io/evict-vms-during-update: "true"
          portworx.io/health-check: passed
         portworx.io/preflight-check: skip
    creationTimestamp: "2025-10-14T05:15:07Z"
  3. Add imagePullPolicy as IfNotPresent
    helm upgrade my-release ./charts/portworx -n portworx --create-namespace --debug --set imagePullPolicy=IfNotPresent
apiVersion: core.libopenstorage.org/v1
kind: StorageCluster
metadata:
  annotations:
    meta.helm.sh/release-name: my-release
    meta.helm.sh/release-namespace: portworx
    portworx.io/health-check: passed
    portworx.io/preflight-check: skip
  creationTimestamp: "2025-10-14T05:15:07Z"
  finalizers:
  - operator.libopenstorage.org/delete
  generation: 3
  labels:
    app.kubernetes.io/instance: my-release
    app.kubernetes.io/managed-by: Helm
    chart: portworx-7.0.3
    heritage: Helm
    release: my-release
  name: mycluster
  namespace: portworx
  resourceVersion: "435954"
  uid: 910a3f6d-90bd-4879-af54-08babcd4de29
spec:
  autopilot:
    enabled: true
    providers:
    - name: default
      params:
        url: http://px-prometheus:9090
      type: prometheus
  csi:
    enabled: true
    installSnapshotController: true
  image: portworx/oci-monitor:3.4.1
  imagePullPolicy: IfNotPresent
  kvdb:
    enableTLS: false
    internal: true
  monitoring:
    telemetry: {}
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
        - matchExpressions:
          - key: px/enabled
            operator: NotIn
            values:
            - "false"
          - key: node-role.kubernetes.io/master
            operator: DoesNotExist
          - key: node-role.kubernetes.io/control-plane
            operator: DoesNotExist
        - matchExpressions:
          - key: px/enabled
            operator: NotIn
            values:
            - "false"
          - key: node-role.kubernetes.io/master
            operator: Exists
          - key: node-role.kubernetes.io/worker
            operator: Exists
        - matchExpressions:
          - key: px/enabled
            operator: NotIn
            values:
            - "false"
          - key: node-role.kubernetes.io/control-plane
            operator: Exists
          - key: node-role.kubernetes.io/worker
            operator: Exists

@hitesh-wani-px hitesh-wani-px marked this pull request as ready for review October 14, 2025 06:27
@hitesh-wani-px hitesh-wani-px force-pushed the customer-req-PWX-47673-PWX-47672 branch from 22cf1c5 to 3b77452 Compare October 14, 2025 06:48
@hitesh-wani-px hitesh-wani-px force-pushed the customer-req-PWX-47673-PWX-47672 branch from 3b77452 to 80676c8 Compare October 14, 2025 06:49

@nikita-bhatia nikita-bhatia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hitesh-wani-px hitesh-wani-px merged commit 926b8ef into pre-release-portworx-7.0.3 Oct 14, 2025
hitesh-wani-px added a commit that referenced this pull request Oct 17, 2025
* Helm release for PX 3.4.1 and op-25.3.1

* change operator version to 25.4.0

* PWX-47568 | Add seLinuxMount in CSI spec (#818)

* PWX-47673 | PWX-47672 | Add support for imagePullPolicy, annotations and verbose operator logs (#817)

* PWX-47673 | PWX-47672 | Add support for imagePullPolicy, annotations and verbose operator logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants