Follow-up: Pydantic eval runtime models and CLI/docs alignment by jt-poolside · Pull Request #25 · poolsideai/bridge-sdk

jt-poolside · 2026-03-12T21:00:42Z

Summary

Migrate eval runtime types (EvalResult, StepEvalContext, PipelineEvalContext, metadata/result models) from dataclasses to Pydantic models.
Replace manual eval context parsing with TypeAdapter validation in EvalFunction.
Support Pydantic generic aliases in eval schema/type extraction (eval_data).
Remove fragile getattr fallback for pipeline eval_bindings in DSL assembly.
Align docs and skill references to the canonical CLI command: bridge eval run.

Why

Addresses post-merge review feedback on model consistency and validation.
Removes brittle indirection and stale command documentation.

Validation

Ran: .venv/bin/pytest -q tests/test_eval.py tests/test_step.py tests/test_pipeline.py tests/test_invoke_step.py tests/test_serialization.py
Result: 146 passed (2 existing serialization warnings).

Note

No Forge command change needed; Forge already invokes bridge eval run.

- migrate eval context/result/metadata types from dataclasses to Pydantic models\n- replace manual eval context construction with TypeAdapter validation\n- support Pydantic generic metadata in eval schema/type extraction\n- remove fragile getattr fallback for pipeline eval_bindings DSL emission\n- update eval tests for new validation/runtime behavior

- replace run-eval wording with eval run in README and bridge-pipelines skill docs\n- keep docs consistent with current CLI command structure

tests/test_eval.py

bridge_sdk/eval_types.py

bridge_sdk/eval_function.py

tkpoolside

LGTM once comments resolved!

- remove redundant payload defaults now covered by Pydantic model defaults\n- move ValidationError import to module top in eval tests

# Conflicts: # bridge_sdk/cli.py

jt-poolside added 2 commits March 12, 2026 15:44

Align eval command docs to bridge eval run

c446235

- replace run-eval wording with eval run in README and bridge-pipelines skill docs\n- keep docs consistent with current CLI command structure

jt-poolside requested a review from tkpoolside March 12, 2026 22:38