Skip to content
This repository was archived by the owner on Feb 8, 2022. It is now read-only.

Added tvOS compatibility#76

Merged
mariabernis merged 1 commit into
appleTVfrom
feature/addTVOSTarget
May 5, 2016
Merged

Added tvOS compatibility#76
mariabernis merged 1 commit into
appleTVfrom
feature/addTVOSTarget

Conversation

@mariabernis

@mariabernis mariabernis commented May 4, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎩 What? Why?

Adding a new tvOS target to support RRC in Apple TV projects

👪 Dependencies?

Head of the 🚂 is #75

📋 Developer checklist

  • Documentation
  • Unit Tests
  • Update README (if necessary)

👻 GIF

@fernandogcat

fernandogcat commented May 4, 2016

Copy link
Copy Markdown
Collaborator

👍

1 similar comment
@ritxart

ritxart commented May 4, 2016

Copy link
Copy Markdown

👍

polqf
polqf reviewed May 4, 2016
View reviewed changes
Comment thread RealmResultsController.xcodeproj/project.pbxproj
isa = PBXGroup;
children = (
83328AD01CD8C96400B70630 /* Realm.framework */,
83328AD11CD8C96400B70630 /* RealmSwift.framework */,

@polqf polqf May 4, 2016 •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you are adding it twice? (see lines below) Seems like the Frameworks folder has both Realm FW duplicated

@mariabernis mariabernis May 4, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but they are different frameworks: one for iOS (dragged from Builds/iOS) and another for tvOS (from Builds/tvOS)

@andresgutgon andresgutgon May 4, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAT? Is @poolqf in the team again?

@polqf polqf May 4, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put them in different folders? iOS and tvOS inside the Frameworks folder 🙏

@mariabernis

mariabernis commented May 4, 2016

Copy link
Copy Markdown
Contributor Author

ok, will do!

@mariabernis mariabernis force-pushed the feature/addTVOSTarget branch from 13ab0e2 to 9a36153 Compare May 5, 2016 09:47
@mariabernis

mariabernis commented May 5, 2016

Copy link
Copy Markdown
Contributor Author

Grouping frameworks in folders makes them to not compile. Looks like it's not that straightforward.
You can check how other libraries are doing this, they all have several frameworks in the Products or Frameworks group, eg. Haneke, Alamofire.
Mergin

@mariabernis mariabernis merged commit d0542d0 into appleTV May 5, 2016
@mariabernis mariabernis deleted the feature/addTVOSTarget branch May 5, 2016 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mariabernis @fernandogcat @ritxart @andresgutgon @polqf