refactor!: modern ES6 rewrite (ESM + node:test, 0 vulns)#25
Merged
Conversation
pocketrocket
force-pushed
the
fix/es6-modernize
branch
from
0a8c80a to
4025d19
Compare
From-scratch modernization (supersedes the 2019 Babel PR #6): - src/floatify.js: ES6 (const/let/arrow), pure ESM (export default). Algorithm unchanged — all 281 assertions pass. - ESM module: package.json "type": "module" + exports. Drops Babel entirely (Node runs ES6 natively). - Tests: migrated to Node's built-in test runner (node:test + node:assert), removing mocha + c8 — which eliminates the glob deprecation and the serialize-javascript (RCE) / diff (DoS) advisories at the root. `npm audit` => 0 vulnerabilities. - eslint flat config (eslint 9); dropped babel-eslint, airbnb-es5, and the legacy .travis.yml / .scrutinizer.yml. BREAKING: now ESM-only (export default) — consumers must `import` instead of `require()`. Bumped to 2.0.0.
pocketrocket
force-pushed
the
fix/es6-modernize
branch
from
4025d19 to
49904b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From-scratch ES6 modernization — supersedes the long-pending 2019 PR #6.
Changes
src/floatify.js: ES6 (const/let/arrow), pure ESM (export default). Algorithm unchanged — all 281 test assertions pass.node:test+node:assert), removing mocha + c8. This eliminates theglobdeprecation warning and theserialize-javascript(RCE, High) +diff(DoS) advisories at the root →npm auditreports 0 vulnerabilities.babel-eslint,airbnb-es5,.travis.yml,.scrutinizer.yml.eslint.Now ESM-only (
export default) — consumers mustimportinstead ofrequire(). → v2.0.0.Verification (local)
node --test→ 281 passing / 0 failing ·npm audit→ 0 ·eslint→ clean.