Fix const correctness in index_adjacency::serialize() #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serialize() method in index_adjacency (unipartite version) was
incorrectly marked const, but it calls base::serialize(out_file)
which is not a const method (defined in indexed_struct_of_arrays).
This caused compilation errors when trying to serialize graphs:
error: no matching member function for call to 'serialize'
note: candidate function not viable: 'this' argument has type
'const nw::graph::index_adjacency<...>', but method is not
marked const
The bipartite version at line 302 is already correct (no const).
This fix makes the unipartite version consistent.
Fixes compilation when using serialize() on adjacency graphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialize() method in index_adjacency (unipartite version) was incorrectly marked const, but it calls base::serialize(out_file) which is not a const method (defined in indexed_struct_of_arrays).
This caused compilation errors when trying to serialize graphs:
error: no matching member function for call to 'serialize'
note: candidate function not viable: 'this' argument has type
'const nw::graph::index_adjacency<...>', but method is not
marked const
The bipartite version at line 302 is already correct (no const). This fix makes the unipartite version consistent.
Fixes compilation when using serialize() on adjacency graphs.