Add Planet and Universe Screen Reader Description Buttons#1540
Open
AERobert wants to merge 2 commits intopmotschmann:masterfrom
Open
Add Planet and Universe Screen Reader Description Buttons#1540AERobert wants to merge 2 commits intopmotschmann:masterfrom
AERobert wants to merge 2 commits intopmotschmann:masterfrom
Conversation
Adds a visually hidden button on the universe selection screen to speak universe name, description, and gameplay effect.
Adds a visually hidden button on the planet selection screen that speaks the full planet description with the same information that appears in the visual tooltip including biome, orbit, traits, and geology when activated. Also added a line of code to refresh a button when its planet is GECKed. A new function `srPlanetDesc` was added to actions.js to generate the spoken description with a few formatting changes from the original `planetDesc` so it speaks better (in particular, geologic deposits are spoken in a comma-separated list).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most selectable / purchasable items have visually hidden buttons which read their tooltips aloud. One of the current exceptions is new planets and universes, which this PR adds. Planet description buttons are especially helpful since the tooltips contain a lot of info needed for selecting one that screen readers are inconsistent in reading.
Codewise, the biggest change aside from the creation of the buttons themselves was a new function, "srPlanetDesc", which was added. It is essentially a modified version of "planetDesc" but reads the text aloud instead, and contains a few text modifications to improve how the text is read aloud.