Improve Accessibility of Andromeda Armada Display#1539
Open
AERobert wants to merge 2 commits intopmotschmann:masterfrom
Open
Improve Accessibility of Andromeda Armada Display#1539AERobert wants to merge 2 commits intopmotschmann:masterfrom
AERobert wants to merge 2 commits intopmotschmann:masterfrom
Conversation
Add the target system's name to the ARIA labels for the buttons used to move ships within Andromeda. Which is to say, the labels now indicate the system a ship will be removed from or added to. For example, "Add Scout Ship to Gorddon System" or "Remove Dreadnought from Chthonian". The labels also now use the proper names of the ships instead of their internal identifiers.
The current controls for Andromeda ships are confusing when navigating with a screen reader, since it's supposed to visually be a grid (I believe). The changes in this commit improve things, at least during my testing. 1. `is-sr-only` h4 elements are placed before the columns of each ship type with movement controls. 2. Another `is-sr-only` span is added after the h4 elements to better signify that the next number represents the count of that type of ship in the Gateway System. 3. The column consisting of available systems is now hidden using "aria-hidden", as it was simply read as a list of names and was therefore unhelpful for screen readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current controls for Andromeda ships are confusing when navigating with a screen reader, since it's supposed to visually be a grid (I believe). The changes in this PR improve things, at least during my testing. All changes only change the aria or the contents of "is-sr-only" elements, so I am pretty sure nothing changes visually.
is-sr-onlyh4 elements are placed before the columns of each ship type with movement controls.is-sr-onlyspan is added after the h4 elements to better signify that the next number represents the count of that type of ship in the Gateway System.