➕ Add static friction to orbit controls.#427
Open
DanielAtCosmicDNA wants to merge 1 commit intopmndrs:mainfrom
Open
➕ Add static friction to orbit controls.#427DanielAtCosmicDNA wants to merge 1 commit intopmndrs:mainfrom
DanielAtCosmicDNA wants to merge 1 commit intopmndrs:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The orbit controls, when damping is used, behave in a way that the deceleration is excessively long and would tend to infinite if it weren't for the arithmetic precision limitation.
This situation makes comparing the speed to 0 a lengthy process.
What
The solution is to add a static friction parameter that always opposes the movement with fixed configurable strength. This guarantees that the coasting is much more consistent when damping is enabled.
Checklist