Skip to content

Enhance Support for std::optional and Empty std::variant#214

Closed
MangelSpec wants to merge 4 commits into
pmed:masterfrom
MangelSpec:share_branch
Closed

Enhance Support for std::optional and Empty std::variant#214
MangelSpec wants to merge 4 commits into
pmed:masterfrom
MangelSpec:share_branch

Conversation

@MangelSpec
Copy link
Copy Markdown

This pull request introduces mapping for std::optional return types and parameters, providing a more seamless integration with TypeScript's optional parameters.
The new mapping reflects the following TypeScript optional parameter syntax:

var: type | undefined
type? var

In addition, this commit extends std::variant support to include std::monostate, which is treated as an undefined value.

@MangelSpec MangelSpec marked this pull request as ready for review June 4, 2024 13:56
@pmed
Copy link
Copy Markdown
Owner

pmed commented Jun 5, 2024

Hi @MangelSpec

wow, thank you for adding this new featur, it looks really handy!

Maybe you have also a couple of use cases that may be added as test cases in test/test_convert.cpp?

I'm going to merge this PR right after fixing failing CI build, that isn’t green now on the master branch.

@pmed pmed mentioned this pull request Nov 19, 2025
@pmed
Copy link
Copy Markdown
Owner

pmed commented Nov 19, 2025

Hi @MangelSpec, thank you for the contributing! I've added test for your changes and merged them in #231

@pmed pmed closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants