Merged
Conversation
ayjayt
force-pushed
the
andrew/helpers
branch
from
c057484 to
db6fd5f
Compare
Collaborator
Author
|
The fact that this passes on CI should be taking with a grain of salt, need to test more on local machine. |
1. Chrome's security model isn't fully functional when you boot, so starting tabs right away like choreographer does might sometimes work and sometimes not. In particular, data urls can behave very differently depending on how long you wait to create a tab with one: 2. That only applies to Target.createTarget, data urls are fine in all instances with page.Navigate. 3. Thanks to AI for poitning out there would be a race condition in early boots, would really like to know how it knew that though. Don't see how I ever could have resolved that on my own. 4. Page.navigate will freeze itself on a bad resolution, where as creating a tab will only show the bad resolution if you are awaiting a page loaded event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a set of helpers functions and bugs.
It also makes clear a user footgun: if they navigate to a bad URL, chrome
devtools just freezes, waiting for it to finish loading.
We should install a timeout into
create_tabso that this test passes.