Merged
Conversation
emilykl
reviewed
Apr 15, 2025
| "If you have already run the above command and are still " | ||
| "seeing this error, or the above command fails, consult the " | ||
| "Kaleido documentation for next steps: " | ||
| "https://path/to/docs/page/about/installing/dependencies\n" |
Collaborator
There was a problem hiding this comment.
TODO: Update this link -- maybe create a INSTALLATION.md doc in the repo to link to for now?
Otherwise remove the link for now and can add it back later once there's something to link to.
Collaborator
Author
There was a problem hiding this comment.
yeah that's right, dumb of me
emilykl
reviewed
Apr 15, 2025
| return True | ||
|
|
||
| def _need_libs(self) -> bool: # noqa: C901 complexity | ||
| def _verify_libs(self) -> bool: |
Collaborator
There was a problem hiding this comment.
needs docstring explaining what False/True return values mean for this function -- looks like False means "dependencies OK" and True means "dependencies missing OR ldd failed" ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't try to inject deps, just include better documentation.