fix: exporting a large figure hangs#442
Open
EliasTalcott wants to merge 2 commits intoplotly:masterfrom
Open
Conversation
EliasTalcott
force-pushed
the
419-exporting-a-large-figure-hangs
branch
from
6031959 to
24108b2
Compare
Choreographer uses remote debugging pipes to execute Javascript functions in Chrome. These have a receive buffer size of 100MB. Previously, if a spec exceeded this size, we would try to send it anyways and the image export would never complete. This makes it so we chunk large specs to keep each send within the buffer size. chrome ref: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/content/browser/devtools/devtools_pipe_handler.cc#44 issue: plotly#419
EliasTalcott
force-pushed
the
419-exporting-a-large-figure-hangs
branch
from
24108b2 to
7f1a39c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choreographer uses remote debugging pipes to execute Javascript functions in Chrome. These have a receive buffer size of 100MB (reference). Previously, if a spec exceeded this size, we would try to send it anyways and the image export would never complete. This makes it so we chunk large specs to keep each send within the buffer size.
Closes #419