Skip to content

Rework navigationmarker #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
thet wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Rework navigationmarker #1217

thet wants to merge 3 commits into from

Conversation

@thet
Copy link
Member

@thet thet commented Sep 8, 2022 •
edited
Loading

  • Modernized code
  • Simpler, more efficient and flexible navigationmarker
  • Configurable in-path and current classes
  • Some other changes along the way...

@thet thet marked this pull request as draft September 8, 2022 17:50
@thet thet force-pushed the rework-navigationmarker branch 2 times, most recently from 30d04e3 to 312f434 Compare September 9, 2022 20:13
@petschki petschki force-pushed the rework-navigationmarker branch from e41396e to 45b1dc8 Compare February 13, 2023 11:06
@thet thet force-pushed the rework-navigationmarker branch from 45b1dc8 to ef0bfb1 Compare February 13, 2023 23:32
@petschki petschki force-pushed the rework-navigationmarker branch from ef0bfb1 to 1c6e17d Compare November 12, 2024 15:51
@petschki
Copy link
Member

petschki commented Nov 13, 2024

@thet I think we can merge this safely ?

@petschki petschki force-pushed the rework-navigationmarker branch from 1c6e17d to 2326f7e Compare May 7, 2025 05:58
petschki
petschki approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say lets merge...

@petschki petschki force-pushed the rework-navigationmarker branch from 2326f7e to 4241e2a Compare May 8, 2025 15:54
@thet thet force-pushed the rework-navigationmarker branch from 4241e2a to 08df254 Compare May 13, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petschki petschki petschki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thet @petschki