Add Lithuanian language#27
Conversation
dvitonis
commented
Jan 31, 2016
dvitonis
commented
- Parses both feminine and masculine basic numerals in the nominative singular case.
- Converts numbers to masculine basic numerals in the nominative singular case.
as space can be the only separator between words.
for Lithuanian language was added.
|
|
There was a problem hiding this comment.
Please don't change the version. There's no guarantee that the previous version is still 0.4.0 when this pull request is merged. It'll depend on which other changes were made before this happens.
I'll update the version number appropriately before releasing a new version.
There was a problem hiding this comment.
I see your reason, fair enough. Issues fixed.
|
Thank you for your interest in contributing to Numsense. The overall code looks promising, and it compiles without warnings on my machine, and all tests pass 👍 I pointed out a few issue that I think might be worth considering, but it's hardly anything major. |
dvitonis
force-pushed
the
feature/add-lithuanian
branch
from
8c81841 to
df347bf
Compare
|
It builds and runs all tests without warnings on my machine, so from a technical perspective I think we're good to go 👍 As I don't read Lithuanian, I'd like someone who does to review that part of it, if at all possible. I don't expect any errors, but it's always good with a second pair of eyes 😄 |
|
I solicited a review on Twitter: https://twitter.com/ploeh/status/694983221189156865 Please retweet and spread the word 😄 |
…Numsense into feature/add-lithuanian
3 participants
