Feature/structured data weight and dimensions#3437
Open
MaxBentz wants to merge 2 commits intoplentymarkets:stablefrom
Open
Feature/structured data weight and dimensions#3437MaxBentz wants to merge 2 commits intoplentymarkets:stablefrom
MaxBentz wants to merge 2 commits intoplentymarkets:stablefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All changes meet the following requirements
@plentymarkets/plentyshop
I added a conditional output for the values. In my opinion it's better to submit no data than wrong data.
I changed the position of output because of the conditional output, so that there is no unnecessary comma at the end.
I added the unitCode for the dimensions and weight.