-
Notifications
You must be signed in to change notification settings - Fork 6
refactor(package): move SDK from Assets/ import to UPM package in Packages #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tulayha
wants to merge
16
commits into
playroomkit:main
Choose a base branch
from
tulayha:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kages/ Migrates the Unity SDK to a proper UPM package so it can be installed via Package Manager using a Git URL. JS .jslib binaries are now shipped with the package, removing the previous npm build requirement. Adds editor menu tools to simplify setup and mock-mode testing. BREAKING-CHANGE: SDK installation changed from importing into Assets/ (with a Unity project import flow) to installing as a UPM package under Packages/ via Package Manager/Git URL. The previous npm build step for generating .jslib binaries is no longer required because binaries are included. feat(editor): add menu item to import WebGL template feat(editor): add menu item to apply recommended project settings feat(editor): add menu item to add mock-mode prefab to active scene ci: add/update pipelines for UPM package build and tests ci: remove/update legacy workflows tied to Assets/ import flow fix: update references after package migration
momintlh
approved these changes
Jan 29, 2026
Collaborator
|
LGTM, need to just separate editor and runtime dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the Unity SDK to a proper UPM package so it can be installed via Package Manager using a Git URL.
JS .jslib binaries are now shipped with the package, removing the previous npm build requirement.
Adds editor menu tools to simplify setup and mock-mode testing.
BREAKING-CHANGE: SDK installation changed from importing into Assets/ (with a Unity project import flow) to installing as a UPM package under Packages/ via Package Manager/Git URL. The previous npm build step for generating .jslib binaries is no longer required because binaries are included.
feat(package): precompiled binaries for PlayroomKit JS (#139)
feat(package): Upgraded package management support (#111)
feat(editor): add menu item to import WebGL template
feat(editor): add menu item to apply recommended project settings
feat(editor): add menu item to add mock-mode prefab to active scene
ci: add/update pipelines for UPM package build and tests
ci: remove/update legacy workflows tied to Assets/ import flow
fix: update references after package migration