Skip to content

Raise errors in Otel/Sentry#6155

Draft
cnkk wants to merge 6 commits intomasterfrom
raise-errors
Draft

Raise errors in Otel/Sentry#6155
cnkk wants to merge 6 commits intomasterfrom
raise-errors

Conversation

@cnkk
Copy link
Member

@cnkk cnkk commented Mar 11, 2026

No description provided.

@cnkk cnkk added the preview label Mar 11, 2026
@github-actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-6155

queue_target: 500,
queue_interval: 2000,
timeout: 15_000,
timeout: 1_000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err don't think we can afford that

|> SQL.QueryBuilder.build(site)
|> ClickhouseRepo.all(query: query)
rescue
e in [Ch.Error, DBConnection.ConnectionError, Mint.TransportError] ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have all that in log_comment?

ConnectionError AFAIU may be unrelated to the query itself, but a failing checkout for example caused by the query previously made - see plausible/ch#271

@cnkk cnkk marked this pull request as draft March 12, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants