Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/plausible/stats/query.ex
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ defmodule Plausible.Stats.Query do
# Contains information to determine how to combine legacy and new time on page metrics
time_on_page_data: %{},
sql_join_type: :left,
smear_session_metrics: false,
optimize_name_filter?: true
smear_session_metrics: false

require OpenTelemetry.Tracer, as: Tracer

Expand Down
3 changes: 1 addition & 2 deletions lib/plausible/stats/query_builder.ex
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,7 @@ defmodule Plausible.Stats.QueryBuilder do
preloaded_goals: preloaded_goals,
revenue_warning: revenue_warning,
revenue_currencies: revenue_currencies,
debug_metadata: debug_metadata,
optimize_name_filter?: FunWithFlags.enabled?(:optimize_name_filter, for: site)
debug_metadata: debug_metadata
)
end

Expand Down
8 changes: 1 addition & 7 deletions lib/plausible/stats/sql/query_builder.ex
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ defmodule Plausible.Stats.SQL.QueryBuilder do
from(
e in "events_v2",
where: ^SQL.WhereBuilder.build(:events, events_query),
where: ^maybe_derived_name_filter(events_query),
where: ^derived_name_filter(events_query),
select: ^select_event_metrics(events_query)
)

Expand Down Expand Up @@ -130,12 +130,6 @@ defmodule Plausible.Stats.SQL.QueryBuilder do
end
end

defp maybe_derived_name_filter(%{optimize_name_filter?: true} = events_query) do
derived_name_filter(events_query)
end

defp maybe_derived_name_filter(_events_query), do: true

defp derived_name_filter(events_query) do
cond do
goal_breakdown?(events_query) ->
Expand Down
Loading