Skip to content

Add --global-keyspace to branch vtctld move-tables create #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcrauwel merged 2 commits into from
Jul 9, 2026
+11 −3
Merged

Add --global-keyspace to branch vtctld move-tables create #1283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c64b47b
Add --global-keyspace to branch vtctld move-tables create
mcrauwel Jul 8, 2026
2dcc8ec
Bump planetscale-go to v0.178.0
mcrauwel Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ require (
github.com/mitchellh/go-homedir v1.1.0
github.com/muesli/termenv v0.16.0
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
github.com/planetscale/planetscale-go v0.177.0
github.com/planetscale/planetscale-go v0.178.0
github.com/planetscale/psdb v0.0.0-20250717190954-65c6661ab6e4
github.com/planetscale/psdbproxy v0.0.0-20250728082226-3f4ea3a74ec7
github.com/spf13/cobra v1.10.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c/go.mod h1:7rwL4CYBLnjL
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
github.com/planetscale/noglog v0.2.1-0.20210421230640-bea75fcd2e8e h1:MZ8D+Z3m2vvqGZLvoQfpaGg/j1fNDr4j03s3PRz4rVY=
github.com/planetscale/noglog v0.2.1-0.20210421230640-bea75fcd2e8e/go.mod h1:hwAsSPQdvPa3WcfKfzTXxtEq/HlqwLjQasfO6QbGo4Q=
github.com/planetscale/planetscale-go v0.177.0 h1:jVE8uInjGayJ7RLaqwBK7VPgu96U/99dwV2MbbuRywA=
github.com/planetscale/planetscale-go v0.177.0/go.mod h1:paQCI5SgquuoewvMQM7R+r1XJO868bdP6/ihGidYRM0=
github.com/planetscale/planetscale-go v0.178.0 h1:1a+VwVpvV4eAFaeL1bLCPcnWKItuYTSBfD2s8BN+6To=
github.com/planetscale/planetscale-go v0.178.0/go.mod h1:paQCI5SgquuoewvMQM7R+r1XJO868bdP6/ihGidYRM0=
github.com/planetscale/psdb v0.0.0-20250717190954-65c6661ab6e4 h1:Xv5pj20Rhfty1Tv0OVcidg4ez4PvGrpKvb6rvUwQgDs=
github.com/planetscale/psdb v0.0.0-20250717190954-65c6661ab6e4/go.mod h1:M52h5IWxAcbdQ1hSZrLAGQC4ZXslxEsK/Wh9nu3wdWs=
github.com/planetscale/psdbproxy v0.0.0-20250728082226-3f4ea3a74ec7 h1:aRd6vdE1fyuSI4RVj7oCr8lFmgqXvpnPUmN85VbZCp8=
Expand Down
3 changes: 3 additions & 0 deletions internal/cmd/branch/vtctld/move_tables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func MoveTablesCreateCmd(ch *cmdutil.Helper) *cobra.Command {
deferSecondaryKeys bool
onDDL string
shardedAutoIncrementHandling string
globalKeyspace string
sourceTimeZone string
tenantID string
cells []string
Expand Down Expand Up @@ -84,6 +85,7 @@ func MoveTablesCreateCmd(ch *cmdutil.Helper) *cobra.Command {
Tables: flags.tables,
OnDDL: flags.onDDL,
ShardedAutoIncrementHandling: flags.shardedAutoIncrementHandling,
GlobalKeyspace: flags.globalKeyspace,
SourceTimeZone: flags.sourceTimeZone,
TenantID: flags.tenantID,
Cells: flags.cells,
Expand Down Expand Up @@ -132,6 +134,7 @@ func MoveTablesCreateCmd(ch *cmdutil.Helper) *cobra.Command {
cmd.Flags().BoolVar(&flags.deferSecondaryKeys, "defer-secondary-keys", true, "Defer secondary keys during the copy phase")
cmd.Flags().StringVar(&flags.onDDL, "on-ddl", "", "DDL handling strategy (IGNORE, STOP, EXEC, EXEC_IGNORE)")
cmd.Flags().StringVar(&flags.shardedAutoIncrementHandling, "sharded-auto-increment-handling", "", "Auto increment handling for sharded keyspaces")
cmd.Flags().StringVar(&flags.globalKeyspace, "global-keyspace", "", "Unsharded keyspace in which to create the backing sequence tables when --sharded-auto-increment-handling is REPLACE")
cmd.Flags().StringVar(&flags.sourceTimeZone, "source-time-zone", "", "Source time zone")
cmd.Flags().StringVar(&flags.tenantID, "tenant-id", "", "Tenant ID")
cmd.Flags().StringSliceVar(&flags.cells, "cells", nil, "Cells to restrict the workflow to (comma-separated)")
Expand Down
5 changes: 5 additions & 0 deletions internal/cmd/branch/vtctld/move_tables_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ func TestMoveTablesCreate(t *testing.T) {
c.Assert(req.TabletTypes, qt.IsNil)
c.Assert(req.ExcludeTables, qt.IsNil)
c.Assert(req.TenantID, qt.Equals, "")
c.Assert(req.GlobalKeyspace, qt.Equals, "")
c.Assert(req.AtomicCopy, qt.IsNil)
return &ps.VtctldOperationReference{ID: "create-op"}, nil
},
Expand Down Expand Up @@ -183,6 +184,8 @@ func TestMoveTablesCreateWithAllFlags(t *testing.T) {
c.Assert(req.TabletTypes, qt.DeepEquals, []string{"PRIMARY", "REPLICA"})
c.Assert(req.ExcludeTables, qt.DeepEquals, []string{"t1", "t2"})
c.Assert(req.TenantID, qt.Equals, "tenant-123")
c.Assert(req.ShardedAutoIncrementHandling, qt.Equals, "REPLACE")
c.Assert(req.GlobalKeyspace, qt.Equals, "global")
c.Assert(req.AtomicCopy, qt.IsNotNil)
c.Assert(*req.AtomicCopy, qt.IsTrue)
c.Assert(req.AllTables, qt.IsNotNil)
Expand Down Expand Up @@ -215,6 +218,8 @@ func TestMoveTablesCreateWithAllFlags(t *testing.T) {
"--tablet-types", "PRIMARY,REPLICA",
"--exclude-tables", "t1,t2",
"--tenant-id", "tenant-123",
"--sharded-auto-increment-handling", "REPLACE",
"--global-keyspace", "global",
"--atomic-copy",
})
err := cmd.Execute()
Expand Down