fix(ci): fix release-please config to match working norm setup#84
Open
MariusVolkhart wants to merge 1 commit into
Open
fix(ci): fix release-please config to match working norm setup#84MariusVolkhart wants to merge 1 commit into
MariusVolkhart wants to merge 1 commit into
Conversation
release-please-action v5 ignores root-level extra-files — move into packages["."] block. Generic updater v17 ignores search/replace fields and uses x-release-please-version annotations instead — add block annotations to gradle.properties and drop the regex fields. Separate post-release.yml used `on: release: published`, but GitHub blocks that event when the release is created by GITHUB_TOKEN. Move the SNAPSHOT bump into release-please.yml, guarded by release_created output, using release-please's own major/minor/patch outputs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MariusVolkhart
requested review from
ethan-wrasman-pkware and
mbayerPK
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra-filesfrom root level intopackages["."]block — release-please-action v5 ignores root-level extra-filessearch/replaceregex fields — Generic updater v17 usesx-release-please-versionblock annotations instead# x-release-please-start-version/# x-release-please-endannotations togradle.propertiespost-release.yml— GitHub blocksrelease: publishedevent when release is created byGITHUB_TOKEN, so the SNAPSHOT bump never firedrelease-please.yml, guarded byrelease_createdoutputmajor/minor/patchoutputs instead of parsing gradle.propertieschangelog-sectionsandgenerate-release-notesconfigAll fixes were discovered and validated in the norm project (commits 335c87b, a321779, 041a575, fe8e183).
🤖 Generated with Claude Code