Ew/fix regex hang#10
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ethan-wrasman-pkware
requested review from
MariusVolkhart and
RyanLuMaye
as code owners
RyanLuMaye
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was brought to my attention with DSM-3647.
How the DFS was implemented, a single state can get traversed through more than once if reached by a different branch.
Ex:
1st Pass: A -> B -> all children of B are traversed
2nd Pass: C -> B -> all children of B are traversed again
The new method uses memoization, which uses dynamic programming to keep track of the children at any given state, so we do not have to traverse it more than once.
A few other tweaks were made that Claude suggested for some cleanup and optimization with infinite regexes.